Looking good.
https://codereview.chromium.org/279773002/diff/120001/src/builtins.cc
File src/builtins.cc (right):
https://codereview.chromium.org/279773002/diff/120001/src/builtins.cc#newcode390
src/builtins.cc:390: JSArray::ReadOnlyLengthError(array));
As discussed offline: Instead of handling this corner-case here in the
optimized version, could we instead call out to the JS builtin reference
implementation instead? This would make the optimized path simpler.
https://codereview.chromium.org/279773002/diff/120001/src/builtins.cc#newcode594
src/builtins.cc:594: JSArray::ReadOnlyLengthError(array));
Likewise.
https://codereview.chromium.org/279773002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
