LGTM. Just a couple of nits and suggestions left.
https://codereview.chromium.org/279773002/diff/160001/src/array.js
File src/array.js (right):
https://codereview.chromium.org/279773002/diff/160001/src/array.js#newcode606
src/array.js:606: if (len > 0) {
As discussed offline: IMHO SimpleMove shouldn't have any side-effects if
len == 0 here. So this check should be obsolete.
https://codereview.chromium.org/279773002/diff/160001/src/array.js#newcode634
src/array.js:634: if (IS_ARRAY(array) && !is_sealed) {
Likewise, for len == 0 should do the right thing here, so can we
restructure this as follows instead?
if (IS_ARRAY(array) && !is_sealed && len > 0) {
SmartMove(array, 0, 0, len, num_arguments);
} else {
SimpleMove(array, 0, 0, len, num_arguments);
}
https://codereview.chromium.org/279773002/diff/160001/src/builtins.cc
File src/builtins.cc (right):
https://codereview.chromium.org/279773002/diff/160001/src/builtins.cc#newcode592
src/builtins.cc:592:
nit: Only one empty new-line is fine.
https://codereview.chromium.org/279773002/diff/160001/src/ic.cc
File src/ic.cc (right):
https://codereview.chromium.org/279773002/diff/160001/src/ic.cc#newcode1802
src/ic.cc:1802: result,
nit: We should be able to assign to store_handle here, no need for
another local variable. Makes the return statement below simpler.
https://codereview.chromium.org/279773002/diff/160001/src/ic.cc#newcode1804
src/ic.cc:1804: isolate(), object, key, value, NONE, strict_mode()),
nit: Only one white-space in front of NONE here.
https://codereview.chromium.org/279773002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
