On 2014/05/28 18:00:31, vsevik wrote:
Can we add a test?
Yes, we can. Done.
https://chromiumcodereview.appspot.com/306463002/diff/1/src/isolate.cc
File src/isolate.cc (right):
https://chromiumcodereview.appspot.com/306463002/diff/1/src/isolate.cc#newcode1727
src/isolate.cc:1727: // Return true. if we don't pending message and can
remove
it
Either comment on particular actions inside the method or add a comment
to the
method declaration if you want to document its behavior as a whole.
Comment moved to method declaration. Done.
https://chromiumcodereview.appspot.com/306463002/diff/1/src/isolate.cc#newcode1731
src/isolate.cc:1731: bool external_caught = IsExternallyCaught();
I think correct naming for the methods would be HasExternalTryCatch and
IsFinallyOnTop now.
Done.
https://codereview.chromium.org/306463002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
