LGTM from my end as well. Just nits. Sorry for the delay.
https://codereview.chromium.org/306463002/diff/80001/src/isolate.h
File src/isolate.h (right):
https://codereview.chromium.org/306463002/diff/80001/src/isolate.h#newcode1182
src/isolate.h:1182: // Propagate pending exception message to the
external try-catch.
nit: s/external try-catch/v8::TryCatch/
https://codereview.chromium.org/306463002/diff/80001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/306463002/diff/80001/test/cctest/test-api.cc#newcode8401
test/cctest/test-api.cc:8401: CHECK_EQ(*exception_value, "1");
Let's call "try_catch.Reset()" here before running the second test
snippet, otherwise we don't have a clean slate.
https://codereview.chromium.org/306463002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
