Looking good. I got some comments. And I would like to add mstarzinger@ for
a
second opinion.
https://chromiumcodereview.appspot.com/306463002/diff/60001/src/isolate.cc
File src/isolate.cc (right):
https://chromiumcodereview.appspot.com/306463002/diff/60001/src/isolate.cc#newcode1154
src/isolate.cc:1154: return false;
Can we simply return an expression?
return (thread_local_top()->catcher_ != NULL) && (try_catch_handler() ==
thread_local_top()->catcher_);
https://chromiumcodereview.appspot.com/306463002/diff/60001/src/isolate.cc#newcode1192
src/isolate.cc:1192: bool canClearMessage =
PropagatePendingExceptionToExternalTryCatch();
please name this 'can_clear_message' instead.
https://chromiumcodereview.appspot.com/306463002/diff/60001/src/isolate.cc#newcode1220
src/isolate.cc:1220: clear_pending_message();
no line break here.
https://chromiumcodereview.appspot.com/306463002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
