Drive-by comments.

https://codereview.chromium.org/332443002/diff/20001/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/332443002/diff/20001/src/preparser.h#newcode1607
src/preparser.h:1607: is_computed_name = true;
Shouldn't the detection of this syntax live behind a flag for now?

https://codereview.chromium.org/332443002/diff/20001/test/mjsunit/object-literal-computed-names.js
File test/mjsunit/object-literal-computed-names.js (right):

https://codereview.chromium.org/332443002/diff/20001/test/mjsunit/object-literal-computed-names.js#newcode5
test/mjsunit/object-literal-computed-names.js:5: // Test computed
properties syntax.
This file should definitely go into the "harmony" or one of the "esN"
sub-directories.

https://codereview.chromium.org/332443002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to