https://codereview.chromium.org/332443002/diff/20001/src/ast.h
File src/ast.h (right):
https://codereview.chromium.org/332443002/diff/20001/src/ast.h#newcode1455
src/ast.h:1455: bool is_computed_name);
On 2014/06/16 08:32:27, wingo wrote:
On 2014/06/13 15:19:24, rossberg wrote:
> Is this flag needed? Isn't it implied by the type of key Expression
node?
The flag is needed. ['foo']:42 has a Literal as the expression node.
We can't
just treat it as foo:42 because of computed names don't participate in
the
early-error-on-duplicate-key stuff.
Apparently, it was decided to drop duplicate checking altogether at the
last meeting (scroll down to Conclusion/Resolution):
http://esdiscuss.org/notes/2014-06-06#rest-properties-and-spread-properties-sebastian-markb-ge-
Not sure I like that, but hey, it's JavaScript.
https://codereview.chromium.org/332443002/diff/20001/src/ia32/full-codegen-ia32.cc
File src/ia32/full-codegen-ia32.cc (right):
https://codereview.chromium.org/332443002/diff/20001/src/ia32/full-codegen-ia32.cc#newcode1704
src/ia32/full-codegen-ia32.cc:1704: // Object literals have two parts.
The "static" part on the left contains no
On 2014/06/16 08:32:27, wingo wrote:
On 2014/06/13 15:19:24, rossberg wrote:
> I'm not convinced that it's best to duplicate this whole loop, given
that it
> shares a lot of (sub)cases. I found the previous version with the
phase flag
> somewhat more pleasant.
I tried to do this at first, but ran into problems with accessors.
Notably, in
the original code accessors are not set until the end, to allow the
AccessorsTable to accumulate both the getter and the setter for a
value. These
values are then set together in a post-pass.
However in the computed properties case we need to set the "get" and
"set"
accessors separately, when we see them.
I also had problems getting the switch fallthrough logic to do the
right thing.
I can give it another go if you think it's the right thing.
Perhaps this problem also goes away with the spec change quoted above?
https://codereview.chromium.org/332443002/diff/60001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/332443002/diff/60001/src/preparser.h#newcode1613
src/preparser.h:1613: }
Add a fall-through comment
https://codereview.chromium.org/332443002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
