https://codereview.chromium.org/332443002/diff/20001/src/ast.h
File src/ast.h (right):
https://codereview.chromium.org/332443002/diff/20001/src/ast.h#newcode1455
src/ast.h:1455: bool is_computed_name);
Is this flag needed? Isn't it implied by the type of key Expression
node?
https://codereview.chromium.org/332443002/diff/20001/src/ia32/full-codegen-ia32.cc
File src/ia32/full-codegen-ia32.cc (right):
https://codereview.chromium.org/332443002/diff/20001/src/ia32/full-codegen-ia32.cc#newcode1704
src/ia32/full-codegen-ia32.cc:1704: // Object literals have two parts.
The "static" part on the left contains no
I'm not convinced that it's best to duplicate this whole loop, given
that it shares a lot of (sub)cases. I found the previous version with
the phase flag somewhat more pleasant.
https://codereview.chromium.org/332443002/diff/20001/src/ia32/full-codegen-ia32.cc#newcode1761
src/ia32/full-codegen-ia32.cc:1761:
accessor_table.lookup(key->AsLiteral())->second;
Is this correct? Can't accessors have computed property names as well?
https://codereview.chromium.org/332443002/diff/20001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/332443002/diff/20001/src/preparser.h#newcode1607
src/preparser.h:1607: is_computed_name = true;
On 2014/06/13 08:14:18, Michael Starzinger wrote:
Shouldn't the detection of this syntax live behind a flag for now?
I agree, we should have --harmony-object-literals (which later might
also include short method forms).
https://codereview.chromium.org/332443002/diff/20001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/332443002/diff/20001/src/runtime.cc#newcode5498
src/runtime.cc:5498: static MaybeHandle<Object> PutOwnElement(Isolate*
isolate,
Nit: SetOwnElement
https://codereview.chromium.org/332443002/diff/20001/src/runtime.cc#newcode5521
src/runtime.cc:5521: static MaybeHandle<Object> PutOwnProperty(Isolate*
isolate,
Nit: SetOwnProperty
https://codereview.chromium.org/332443002/diff/20001/src/runtime.h
File src/runtime.h (right):
https://codereview.chromium.org/332443002/diff/20001/src/runtime.h#newcode228
src/runtime.h:228: F(PutOwnProperty, 3, 1) \
Let's call this SetOwnProperty for consistency.
https://codereview.chromium.org/332443002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
