On 2014/06/16 08:32:27, wingo wrote:
Updated patch, PTAL. I can give another go at the code generation stuff.
Marja thank you very much for pointing out my embarrassing not-working
hack.
I
have fixed it and tested again in GDB to ensure that we hit the
pre-parsing
case.
I think you should add test cases to test-parsing.cc (see the cases which
call
RunParserSyncTest) - they will surely invoke the PreParser and test that it
produces the same errors as the Parser (and accepts the same language).
https://codereview.chromium.org/332443002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
