On Mon, 2 Mar 2026 18:09:20 GMT, Joe Darcy <[email protected]> wrote:
>> David Beaumont has updated the pull request incrementally with one >> additional commit since the last revision: >> >> More tests and tidying > > make/jdk/src/classes/build/tools/valhalla/valuetypes/GenValueClasses.java > line 166: > >> 164: Files.createDirectories(outPath.getParent()); >> 165: >> 166: List<Long> insertPositions = > > I'll just note it should be technically possible to also generate the > modified version of the sources using by printing out a version of the AST in > javac. Indeed. The code for doing that while injecting the new keyword (in an AST that doesn't yet understand the new `value` keyword) was challenging. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2180#discussion_r2877530884
