On Fri, 8 May 2026 00:48:35 GMT, Dean Long <[email protected]> wrote:
>> Coleen Phillimore has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - include another file. >> - Some forward declarations might do the trick. > > .github/workflows/build-cross-compile.yml line 2: > >> 1: # >> 2: # Copyright (c) 2022, 2026, Oracle and/or its affiliates. All rights >> reserved. > > Since this is essentially reverted to an earlier version, making it the same > as mainline jdk, I think there is a good argument for reverting the copyright > date as well. But then our automatic scripts will probably blinding update > it anyway, so it probably doesn't matter. I can fix this. I don't think they will update it if there's no changes in the main PR. > src/hotspot/share/cds/filemap.hpp line 129: > >> 127: inline static void do_print(outputStream* st, uint v); >> 128: inline static void do_print(outputStream* st, intx v); >> 129: LP64_ONLY(inline static void do_print(outputStream* st, uintx v);) > > Considering using uintx for both 32- and 64-bit and removing "uint" version. I can reverse these and not have uint instead. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2396#discussion_r3209034985 PR Review Comment: https://git.openjdk.org/valhalla/pull/2396#discussion_r3209021303
