On Thu, 7 May 2026 21:39:14 GMT, Coleen Phillimore <[email protected]> wrote:
>> Add a bunch of stubs and parameter changes to get non-Oracle platforms to >> compile. Tested with cross compilation in mach5. Also enabled GHA for >> these platforms. Tested tier1 with Oracle platforms. >> >> Porters please let me know if this runs hello world, then the rest is up to >> you. >> Thank you! >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Coleen Phillimore has updated the pull request incrementally with two > additional commits since the last revision: > > - include another file. > - Some forward declarations might do the trick. src/hotspot/cpu/ppc/c1_LIRGenerator_ppc.cpp line 846: > 844: LIR_Opr tmp3 = FrameMap::R7_oop_opr; > 845: LIR_Opr tmp4 = FrameMap::R8_oop_opr; > 846: new_instance(reg, x->klass(), x->is_unresolved(), false, tmp1, tmp2, > tmp3, tmp4, klass_reg, info); Suggestion: new_instance(reg, x->klass(), x->is_unresolved(), /* allow_inline */ false, tmp1, tmp2, tmp3, tmp4, klass_reg, info); src/hotspot/cpu/riscv/c1_LIRGenerator_riscv.cpp line 916: > 914: LIR_Opr reg = result_register_for(x->type()); > 915: new_instance(reg, x->klass(), x->is_unresolved(), > 916: false, Suggestion: /* allow_inline */ false, src/hotspot/cpu/s390/c1_LIRGenerator_s390.cpp line 780: > 778: LIR_Opr tmp4 = LIR_OprFact::illegalOpr; > 779: LIR_Opr klass_reg = FrameMap::Z_R11_metadata_opr; > 780: new_instance(reg, x->klass(), x->is_unresolved(), false, tmp1, tmp2, > tmp3, tmp4, klass_reg, info); Suggestion: new_instance(reg, x->klass(), x->is_unresolved(), /* allow_inline */ false, tmp1, tmp2, tmp3, tmp4, klass_reg, info); ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2396#discussion_r3205801105 PR Review Comment: https://git.openjdk.org/valhalla/pull/2396#discussion_r3205802632 PR Review Comment: https://git.openjdk.org/valhalla/pull/2396#discussion_r3205804292
