On Thu, 7 May 2026 21:39:14 GMT, Coleen Phillimore <[email protected]> wrote:

>> Add a bunch of stubs and parameter changes to get non-Oracle platforms to 
>> compile.  Tested with cross compilation in mach5.  Also enabled GHA for 
>> these platforms.  Tested tier1 with Oracle platforms.
>> 
>> Porters please let me know if this runs hello world, then the rest is up to 
>> you.
>> Thank you!
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Coleen Phillimore has updated the pull request incrementally with two 
> additional commits since the last revision:
> 
>  - include another file.
>  - Some forward declarations might do the trick.

src/hotspot/cpu/arm/c1_LIRGenerator_arm.cpp line 947:

> 945:   LIR_Opr tmp3 = FrameMap::LR_oop_opr;
> 946: 
> 947:   new_instance(reg, x->klass(), x->is_unresolved(), false, tmp1, tmp2, 
> tmp3,

Suggestion:

  new_instance(reg, x->klass(), x->is_unresolved(), /* allow_inline */ false, 
tmp1, tmp2, tmp3,

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2396#discussion_r3205594860

Reply via email to