On Thu, 7 May 2026 21:39:14 GMT, Coleen Phillimore <[email protected]> wrote:

>> Add a bunch of stubs and parameter changes to get non-Oracle platforms to 
>> compile.  Tested with cross compilation in mach5.  Also enabled GHA for 
>> these platforms.  Tested tier1 with Oracle platforms.
>> 
>> Porters please let me know if this runs hello world, then the rest is up to 
>> you.
>> Thank you!
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Coleen Phillimore has updated the pull request incrementally with two 
> additional commits since the last revision:
> 
>  - include another file.
>  - Some forward declarations might do the trick.

src/hotspot/cpu/arm/arm.ad line 846:

> 844: #ifndef PRODUCT
> 845: void MachVEPNode::format(PhaseRegAlloc* ra_, outputStream* st) const
> 846: {

Suggestion:

{
  Unimplemented();

src/hotspot/cpu/arm/arm.ad line 851:

> 849: 
> 850: void MachVEPNode::emit(C2_MacroAssembler *masm, PhaseRegAlloc* ra_) const
> 851: {

Suggestion:

{
  Unimplemented();

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2396#discussion_r3205581508
PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2396#discussion_r3205582921

Reply via email to