> Can I please get a review of this test-only change which addresses the issues 
> in its parameterized tests, as noted here 
> https://github.com/openjdk/jdk/pull/31123/changes#r3486082890?
> 
> While at it, I also did a general clean up of the test and added comments to 
> the test methods and the classes used in that test to clarify what's being 
> covered by this test.
> 
> The test continues to pass after this change and the test methods get run 
> more number of times (as expected) due to fixing the parameters being 
> generated for the parameterized tests.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Jaikiran Pai has updated the pull request incrementally with one additional 
commit since the last revision:

  rename methods

-------------

Changes:
  - all: https://git.openjdk.org/valhalla/pull/2590/files
  - new: https://git.openjdk.org/valhalla/pull/2590/files/05b469b2..d4ba0e34

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=valhalla&pr=2590&range=01
 - incr: https://webrevs.openjdk.org/?repo=valhalla&pr=2590&range=00-01

  Stats: 7 lines in 1 file changed: 0 ins; 0 del; 7 mod
  Patch: https://git.openjdk.org/valhalla/pull/2590.diff
  Fetch: git fetch https://git.openjdk.org/valhalla.git pull/2590/head:pull/2590

PR: https://git.openjdk.org/valhalla/pull/2590

Reply via email to