On Mon, 29 Jun 2026 13:56:39 GMT, Chen Liang <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> adjust test method comment
>
> test/jdk/java/io/Serializable/valueObjects/ValueSerializationTest.java line
> 144:
>
>> 142: }
>> 143:
>> 144: static Stream<Arguments> serializingInstances() {
>
> If you have only one argument for your parameterized test, you can use a
> `Stream<Object>` or `Object[]` where each element is used as the single
> argument to the invoked test. This avoids `Arguments.of()` and the varargs
> casts.
That's a good idea. I've updated the PR to remove the use of `Arguments` here.
> test/jdk/java/io/Serializable/valueObjects/ValueSerializationTest.java line
> 216:
>
>> 214: assertArrayEquals((Object[]) actual, (Object[]) obj);
>> 215: } else {
>> 216: assertEquals(actual, obj);
>
> JUnit places "expected" argument in the first position and the "actual"
> argument in the second position. So swap the arguments.
Good catch. Fixed.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2590#discussion_r3500397464
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2590#discussion_r3500398763
