On Mon, 29 Jun 2026 14:48:53 GMT, Viktor Klang <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> move the assertThrows() more closer to the actual
>> readObject()/writeObject() invocation
>
> test/jdk/java/io/Serializable/valueObjects/ValueSerializationTest.java line
> 275:
>
>> 273: if (expectedException != null) {
>> 274: Exception e = assertThrows(expectedException, () ->
>> oos.writeObject(obj));
>> 275: System.err.println("got expected exception: " + e);
>
> Drop this?
Removed in the updated version of the PR.
> test/jdk/java/io/Serializable/valueObjects/ValueSerializationTest.java line
> 291:
>
>> 289: if (expectedException != null) {
>> 290: Exception e = assertThrows(expectedException, () ->
>> ois.readObject());
>> 291: System.err.println("got expected exception: " + e);
>
> Drop this?
Removed in the updated version of the PR.
> test/jdk/java/io/Serializable/valueObjects/ValueSerializationTest.java line
> 458:
>
>> 456: } else {
>> 457: return false;
>> 458: }
>
> Saving a bit of vertical space:
>
> Suggestion:
>
> return other instanceof ExtValueWithIdentityReplacement foo &&
> s.equals(foo.s);
Done
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2590#discussion_r3500400221
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2590#discussion_r3500400590
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2590#discussion_r3500401249
