On Sat, 27 Jun 2026 16:31:09 GMT, Jaikiran Pai <[email protected]> wrote:
>> Can I please get a review of this test-only change which addresses the >> issues in its parameterized tests, as noted here >> https://github.com/openjdk/jdk/pull/31123/changes#r3486082890? >> >> While at it, I also did a general clean up of the test and added comments to >> the test methods and the classes used in that test to clarify what's being >> covered by this test. >> >> The test continues to pass after this change and the test methods get run >> more number of times (as expected) due to fixing the parameters being >> generated for the parameterized tests. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last revision: > > move the assertThrows() more closer to the actual > readObject()/writeObject() invocation test/jdk/java/io/Serializable/valueObjects/ValueSerializationTest.java line 275: > 273: if (expectedException != null) { > 274: Exception e = assertThrows(expectedException, () -> > oos.writeObject(obj)); > 275: System.err.println("got expected exception: " + e); Drop this? test/jdk/java/io/Serializable/valueObjects/ValueSerializationTest.java line 291: > 289: if (expectedException != null) { > 290: Exception e = assertThrows(expectedException, () -> > ois.readObject()); > 291: System.err.println("got expected exception: " + e); Drop this? ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2590#discussion_r3492574957 PR Review Comment: https://git.openjdk.org/valhalla/pull/2590#discussion_r3492575576
