On Wed, 1 Jul 2026 14:38:39 GMT, Viktor Klang <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> move serialize/deserialize to call sites
>
> test/jdk/java/io/Serializable/valueObjects/ValueSerializationTest.java line
> 360:
>
>> 358: @Override
>> 359: public void writeExternal(ObjectOutput out) {
>> 360: }
>
> Would be good to include a comment stating why these methods are empty.
I've added some additional code comments to each of such methods to explain
their role and also tightened those expectations by asserting in those methods.
The PR has been updated with these changes and the test continues to pass.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2590#discussion_r3507366550
