On Tue, 30 Jun 2026 16:45:39 GMT, Jaikiran Pai <[email protected]> wrote:
>> Can I please get a review of this test-only change which addresses the >> issues in its parameterized tests, as noted here >> https://github.com/openjdk/jdk/pull/31123/changes#r3486082890? >> >> While at it, I also did a general clean up of the test and added comments to >> the test methods and the classes used in that test to clarify what's being >> covered by this test. >> >> The test continues to pass after this change and the test methods get run >> more number of times (as expected) due to fixing the parameters being >> generated for the parameterized tests. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Jaikiran Pai has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 11 additional > commits since the last revision: > > - merge latest from lworld branch > - @build for test library classes used in the test > - no need for Arguments > - Chen's review - switch param order on junit asserts > - Viktor's reviews > - adjust test method comment > - fix comment typo > - Viktor's review - add code comment in test > - move the assertThrows() more closer to the actual > readObject()/writeObject() invocation > - rename methods > - ... and 1 more: > https://git.openjdk.org/valhalla/compare/2f38dae8...1692dbf9 I've implemented the review suggestions and updated the PR. The test continues to pass as expected with these changes. ------------- PR Comment: https://git.openjdk.org/valhalla/pull/2590#issuecomment-4845930839
