On Mon, 29 Jun 2026 13:58:26 GMT, Chen Liang <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> adjust test method comment > > test/jdk/java/io/Serializable/valueObjects/ValueSerializationTest.java line > 285: > >> 283: } >> 284: >> 285: private static <T> byte[] serialize(T obj, Class<? extends >> Exception> expectedException) > > I find that `expectedException` is always null in one site and always > non-null in another site. I recommend inlining this method to the > corresponding places given we have a very ugly branching `if > (expectedException != null)`. Same remark for `deserialize`. Done. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2590#discussion_r3500459665
