On Tue, 14 Jul 2026 17:07:40 GMT, Chen Liang <[email protected]> wrote:

>> This is some extremely basic overview about value class migrations.
>> 
>> 1. Build: I intentionally skipped the streamlined build system installed by 
>> David Beaumont. Instead, I stressed the custom handling used by Value 
>> Objects JEP. (The "Preview Classes in Interim `javac`" section might go to 
>> general documentation later.)
>> 
>> 2. Testing: I started from the motivations/goals and describe how those 
>> goals are accomplished.
>> 3. Wrapper class caches: Some simple overview.
>> 
>> There are definitely more topics to cover; feel free to raise.
>> 
>> Paging @jddarcy and @viktorklang-ora for proofreading.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Chen Liang has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Remove "classpath"

doc/value-class-preview.md line 37:

> 35: 
> 36: 4. The general preview source to binary build pipeline recognizes this
> 37:    directory as where `java.base` places its preview-specific source 
> files.

@liach This text is sort of ambiguous about whether the original files still 
remain in place, I think it should be spelled out that the original remains in 
place, and that the value-capable version of the source is a transformed copy.

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2633#discussion_r3587663832

Reply via email to