On Fri, 17 Jul 2026 15:26:14 GMT, Chen Liang <[email protected]> wrote:

>> This is some extremely basic overview about value class migrations.
>> 
>> 1. Build: I intentionally skipped the streamlined build system installed by 
>> David Beaumont. Instead, I stressed the custom handling used by Value 
>> Objects JEP. (The "Preview Classes in Interim `javac`" section might go to 
>> general documentation later.)
>> 
>> 2. Testing: I started from the motivations/goals and describe how those 
>> goals are accomplished.
>> 3. Wrapper class caches: Some simple overview.
>> 
>> There are definitely more topics to cover; feel free to raise.
>> 
>> Paging @jddarcy and @viktorklang-ora for proofreading.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Chen Liang has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Typos spotted by Viktor

Marked as reviewed by dlsmith (Committer).

doc/value-class-preview.md line 62:

> 60: 
> 61: 5. At run-time, jimage will pick up the preview-specific overrides from
> 62:    `META-INF/preview` only when features are enabled.

when _preview_ features

doc/value-class-preview.md line 87:

> 85:    disabled. There's no plan to introduce completely new value classes.
> 86: 
> 87: Support for other value classes require significant changes to the build 
> system.

_would_ require

doc/value-class-preview.md line 110:

> 108: a non-flat array storing object references, allowing a value object 
> wrapping
> 109: a primitive value to be available quickly without redundant allocations 
> and
> 110: associated performance regressions. Their existence have no semantic 
> meaning,

_has_ no semantic meaning

-------------

PR Review: 
https://git.openjdk.org/valhalla/pull/2633#pullrequestreview-4724024978
PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2633#discussion_r3604299716
PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2633#discussion_r3604310594
PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2633#discussion_r3604319288

Reply via email to