On Thu, 16 Jul 2026 15:07:10 GMT, Chen Liang <[email protected]> wrote:

>> This is some extremely basic overview about value class migrations.
>> 
>> 1. Build: I intentionally skipped the streamlined build system installed by 
>> David Beaumont. Instead, I stressed the custom handling used by Value 
>> Objects JEP. (The "Preview Classes in Interim `javac`" section might go to 
>> general documentation later.)
>> 
>> 2. Testing: I started from the motivations/goals and describe how those 
>> goals are accomplished.
>> 3. Wrapper class caches: Some simple overview.
>> 
>> There are definitely more topics to cover; feel free to raise.
>> 
>> Paging @jddarcy and @viktorklang-ora for proofreading.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Chen Liang has updated the pull request with a new target base due to a merge 
> or a rebase. The incremental webrev excludes the unrelated changes brought in 
> by the merge/rebase. The pull request contains 10 additional commits since 
> the last revision:
> 
>  - Latest viktor reviews
>  - Merge branch 'lworld' of https://github.com/openjdk/valhalla into 
> doc/lw-value-migration
>  - Merge branch 'lworld' of https://github.com/openjdk/valhalla into 
> doc/lw-value-migration
>  - Remove "classpath"
>  - Typo
>  - More straightforward
>  - Merge branch 'lworld' of https://github.com/openjdk/valhalla into 
> doc/lw-value-migration
>  - Viktor reviews
>  - Review tweaks
>  - Value class migration docs

doc/value-class-preview.md line 9:

> 7: class files are used for the migrated classes in the Java class library.
> 8: 
> 9: To accomplish this, the JDK uses *preview-specific* files in 
> `META-INF/preview`,

To clarify,
"To accomplish this, a built JDK uses..."

That is, this section is discussing the artifact people run, not the source 
structure, etc.

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2633#discussion_r3597403189

Reply via email to