On Thu, 16 Jul 2026 22:21:04 GMT, Chen Liang <[email protected]> wrote:
>> This is some extremely basic overview about value class migrations. >> >> 1. Build: I intentionally skipped the streamlined build system installed by >> David Beaumont. Instead, I stressed the custom handling used by Value >> Objects JEP. (The "Preview Classes in Interim `javac`" section might go to >> general documentation later.) >> >> 2. Testing: I started from the motivations/goals and describe how those >> goals are accomplished. >> 3. Wrapper class caches: Some simple overview. >> >> There are definitely more topics to cover; feel free to raise. >> >> Paging @jddarcy and @viktorklang-ora for proofreading. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Chen Liang has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains 12 additional commits since > the last revision: > > - Joe remarks > - Merge branch 'lworld' of https://github.com/openjdk/valhalla into > doc/lw-value-migration > - Latest viktor reviews > - Merge branch 'lworld' of https://github.com/openjdk/valhalla into > doc/lw-value-migration > - Merge branch 'lworld' of https://github.com/openjdk/valhalla into > doc/lw-value-migration > - Remove "classpath" > - Typo > - More straightforward > - Merge branch 'lworld' of https://github.com/openjdk/valhalla into > doc/lw-value-migration > - Viktor reviews > - ... and 2 more: > https://git.openjdk.org/valhalla/compare/6712a5ab...9fa9a94f doc/value-class-preview.md line 62: > 60: > 61: 5. At run-time, jimage will pick up the preview-specific overrides from > 62: `META-INF/preview` when preview features are enabled. Suggestion: 5. At run-time, jimage will pick up the preview-specific overrides from `META-INF/preview` only when preview features are enabled. doc/value-class-preview.md line 65: > 63: > 64: 6. The interim `javac` used by the build system cannot pickup the > 65: preview-specific overrides; they must be supplied explicitly with this Suggestion: preview-specific overrides; they must be supplied explicitly with the following ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2633#discussion_r3604206759 PR Review Comment: https://git.openjdk.org/valhalla/pull/2633#discussion_r3604209496
