----- Original Message ----- > From: "Yedidyah Bar David" <d...@redhat.com> > To: "vdsm-devel" <vdsm-de...@fedorahosted.org> > Cc: "Alon Bar-Lev" <alo...@redhat.com>, "Sandro Bonazzola" > <sbona...@redhat.com>, "Antoni Segura Puimedon" > <asegu...@redhat.com> > Sent: Wednesday, November 27, 2013 10:38:54 AM > Subject: addNetwork to use existing nic conf > > Hi all, > > While looking at [1], and reading the source of bridge.py of > ovirt-hosted-engine-setup > and of ovirt-host-deploy, I think the correct thing will be for addNetwork to > not > require either bootproto=dhcp or ipaddr/netmask/etc., but to take this from > the existing > conf of the nics to be put inside the bridge.
You mean the addNetwork in vdsm/vdsm/configNetwork.py? If that is the case I would very much prefer not to make such change, since that would make addNetwork even farther from referential transparency. What I propose is that the calling code will use the new getBootProto introduced in: http://gerrit.ovirt.org/18484 (already merged). > > Does this make sense? > > [1] https://bugzilla.redhat.com/show_bug.cgi?id=1013666 > > Thanks! > -- > Didi > _______________________________________________ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
