On Wed, Nov 27, 2013 at 09:54:06AM -0500, Antoni Segura Puimedon wrote:
> 
> 
> ----- Original Message -----
> > From: "Yedidyah Bar David" <d...@redhat.com>
> > To: "Dan Kenigsberg" <dan...@redhat.com>
> > Cc: "Antoni Segura Puimedon" <asegu...@redhat.com>, "vdsm-devel" 
> > <vdsm-de...@fedorahosted.org>
> > Sent: Wednesday, November 27, 2013 3:47:20 PM
> > Subject: Re: [vdsm] addNetwork to use existing nic conf
> > 
> > ----- Original Message -----
> > > From: "Dan Kenigsberg" <dan...@redhat.com>
> > > To: "Antoni Segura Puimedon" <asegu...@redhat.com>
> > > Cc: "Yedidyah Bar David" <d...@redhat.com>, "vdsm-devel"
> > > <vdsm-de...@fedorahosted.org>
> > > Sent: Wednesday, November 27, 2013 2:51:37 PM
> > > Subject: Re: [vdsm] addNetwork to use existing nic conf
> > > 
> > > On Wed, Nov 27, 2013 at 07:28:23AM -0500, Antoni Segura Puimedon wrote:
> > > > 
> > > > 
> > > > ----- Original Message -----
> > > > > From: "Dan Kenigsberg" <dan...@redhat.com>
> > > > > To: "Antoni Segura Puimedon" <asegu...@redhat.com>
> > > > > Cc: "Yedidyah Bar David" <d...@redhat.com>, "vdsm-devel"
> > > > > <vdsm-de...@fedorahosted.org>
> > > > > Sent: Wednesday, November 27, 2013 1:22:47 PM
> > > > > Subject: Re: [vdsm] addNetwork to use existing nic conf
> > > > > 
> > > > > On Wed, Nov 27, 2013 at 06:55:26AM -0500, Antoni Segura Puimedon 
> > > > > wrote:
> > > > > > 
> > > > > > 
> > > > > > ----- Original Message -----
> > > > > > > From: "Yedidyah Bar David" <d...@redhat.com>
> > > > > > > To: "Antoni Segura Puimedon" <asegu...@redhat.com>
> > > > > > > Cc: "vdsm-devel" <vdsm-de...@fedorahosted.org>, "Alon Bar-Lev"
> > > > > > > <alo...@redhat.com>, "Sandro Bonazzola"
> > > > > > > <sbona...@redhat.com>
> > > > > > > Sent: Wednesday, November 27, 2013 11:18:39 AM
> > > > > > > Subject: Re: addNetwork to use existing nic conf
> > > > > > > 
> > > > > > > ----- Original Message -----
> > > > > > > > From: "Antoni Segura Puimedon" <asegu...@redhat.com>
> > > > > > > > To: "Yedidyah Bar David" <d...@redhat.com>
> > > > > > > > Cc: "vdsm-devel" <vdsm-de...@fedorahosted.org>, "Alon Bar-Lev"
> > > > > > > > <alo...@redhat.com>, "Sandro Bonazzola"
> > > > > > > > <sbona...@redhat.com>
> > > > > > > > Sent: Wednesday, November 27, 2013 11:52:51 AM
> > > > > > > > Subject: Re: addNetwork to use existing nic conf
> > > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > ----- Original Message -----
> > > > > > > > > From: "Yedidyah Bar David" <d...@redhat.com>
> > > > > > > > > To: "vdsm-devel" <vdsm-de...@fedorahosted.org>
> > > > > > > > > Cc: "Alon Bar-Lev" <alo...@redhat.com>, "Sandro Bonazzola"
> > > > > > > > > <sbona...@redhat.com>, "Antoni Segura Puimedon"
> > > > > > > > > <asegu...@redhat.com>
> > > > > > > > > Sent: Wednesday, November 27, 2013 10:38:54 AM
> > > > > > > > > Subject: addNetwork to use existing nic conf
> > > > > > > > > 
> > > > > > > > > Hi all,
> > > > > > > > > 
> > > > > > > > > While looking at [1], and reading the source of bridge.py of
> > > > > > > > > ovirt-hosted-engine-setup
> > > > > > > > > and of ovirt-host-deploy, I think the correct thing will be 
> > > > > > > > > for
> > > > > > > > > addNetwork
> > > > > > > > > to
> > > > > > > > > not
> > > > > > > > > require either bootproto=dhcp or ipaddr/netmask/etc., but to
> > > > > > > > > take
> > > > > > > > > this
> > > > > > > > > from
> > > > > > > > > the existing
> > > > > > > > > conf of the nics to be put inside the bridge.
> > > > > > > > 
> > > > > > > > You mean the addNetwork in vdsm/vdsm/configNetwork.py?
> > > > > > > 
> > > > > > > We currently use vdsClient - 'vdsClient addNetwork'.
> > > > > > > 
> > > > > > > > If that is the case I would very much prefer not to make such
> > > > > > > > change,
> > > > > > > > since
> > > > > > > > that
> > > > > > > > would make addNetwork even farther from referential 
> > > > > > > > transparency.
> > > > > > > > 
> > > > > > > > What I propose is that the calling code will use the new
> > > > > > > > getBootProto
> > > > > > > > introduced in:
> > > > > > > > http://gerrit.ovirt.org/18484 (already merged).
> > > > > > > 
> > > > > > > Does vdsClient support that?
> > > > > > 
> > > > > > Well, vdsClient getVdsCaps returns the cfg information for all the
> > > > > > devices,
> > > > > > part of that will be the bootproto if it is defined on the ifcfg 
> > > > > > file
> > > > > > of
> > > > > > the
> > > > > > device.
> > > > > 
> > > > > We'd very much like to drop the 'cfg' element reported per nic (it
> > > > > breaks Vdsm's "network" abrstraction and would be anoying to maintain
> > > > > with iproute2 when we move to it. "BOOTPROTO" is there, and would have
> > > > > to stay there (for backward compatibility with Engine), but please
> > > > > avoid
> > > > > using any other data.
> > > > 
> > > > Well, for installation time, there must be something (not necessarily
> > > > part
> > > > of
> > > > vdsm proper that is able to get the ip configuration of the device we
> > > > connect
> > > > through.
> > > > 
> > > > Since it could be ifcfg info (el6), NM (newer distros),
> > > > /etc/network/interfaces
> > > > (debian derived) I would really make a separate solution to vdsm.
> > > 
> > > No doubt about that:
> > >     Bug 987813 - [RFE] report BOOTPROTO and BONDING_OPTS independent of
> > >     netdevice.cfg
> > > 
> > 
> > Sorry, I did not understand. Should I or should I not rely on getVdsCaps
> > to get the ipaddr/netmask/gateway/whatever? Just getting bootproto from it
> > does not help much if I have to read ifcfg files anyway.
> 
> getVdsCaps as it stands now is only working on el6 and Fedora for getting the
> bootProto in the cfg field.

...and for ipaddr/netmask/gateway it's the thing to use. Just note to
look for the lowercase values, not for the ones copied from the ifcfg.

Dan.
_______________________________________________
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel

Reply via email to