Shmuel Leib Melamud has posted comments on this change. Change subject: storage: Add inplace virt-sparsify support ......................................................................
Patch Set 13: (1 comment) https://gerrit.ovirt.org/#/c/57347/13/vdsm/storage/sdm/api/sparsify_volume.py File vdsm/storage/sdm/api/sparsify_volume.py: Line 22: Line 23: from vdsm import virtsparsify Line 24: from vdsm.storage import guarded Line 25: Line 26: from .copy_data import CopyDataDivEndpoint > Importing from another verb is ugly. Since CopyDataDivEndpoint is reusable, I've asked Adam in e-mail about this: Me: It will not look good to import copy_data.py from sparsify_volume.py. So, we need to move CopyDataDIVEndpoint to some common place. What place should it be? Adam: For your first patch could you just try and do: from copy_data import CopyDataDIVEndpoint I want to keep the same names as in the schema for clarity. Later on, we can move the implementation of CopyDataDIVEndpoint out to a common module if necessary but I don't want to delay your verb for this. We are simultaneously making improvements to CopyDataDIVEndpoint (locking, etc) and it will be easier to continue development in its current location for now. Line 27: Line 28: from . import base Line 29: Line 30: -- To view, visit https://gerrit.ovirt.org/57347 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ac2bb1fbd2acbe0fc47694d17313c6ccd01a227 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smela...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smela...@redhat.com> Gerrit-Reviewer: Shmuel Melamud <smela...@redhat.com> Gerrit-Reviewer: Yaniv Kaul <yk...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
