Rafael Garcia-Suarez wrote:
On 29/11/2007, John E. Malmberg <[EMAIL PROTECTED]> wrote:
On Tuesday, November 27, 2007, at 11:48AM, "Rafael Garcia-Suarez"
<[EMAIL PROTECTED]> wrote:
Note also: we have a couple of patches pending by John Malmberg, one to
cwd.t and one to File::Spec::VMS (if I don't forget any). I think I may
apply them to bleadperl then, if noone objects.
There are patches for cwd.t and cwd.pm needed for VMS. The cwd.pm from
the CPAN pathtools also works for VMS instead of the cwd.pm patch I
submitted earlier.
The File::Spec::VMS patch is not critical, it eliminates a failure in
what is apparently a new crossplatform.t test in pathtools.
Having the File::Spec::VMS patch in may change what error message or bad
behavior shows up on VMS when running a Perl module written for UNIX
that does not work in VMS now.
Do I need to resubmit the patches?
I just applied the File::Spec::VMS patch, but I think that the
cwd.t/Cwd.pm one has been applied by Craig as #32053 (or I'm confused.)
Can you confirm ?
So I think that what is now in the core is what should be released on CPAN.
Change #32053 is wrong. It does not implement symbolic links for VMS,
it just changes things to look like the test passes on VMS. Sorry to be
the bearer of bad news. I should have looked at it more carefully when
it was applied.
Prior to patch 32474, VMS did not have a C<realpath> equivalent method,
and could not convert paths with symbolic links in them to absolute
paths that did not contain a symbolic link.
The cwd.pm from the Ken's pathtools is the correct one now. Ken did not
pick up the required change to cwd.t to make the test pass on VMS.
It is only different in some formatting issues from the patch I
submitted to blead cwd.pm. So taking the cwd.pm from Ken's current
pathtools may be the best. I do not have a patch submitted for that.
I have submitted two patches for cwd.t, the first one is good against
blead, the second one is good against Ken's current pathtools.
With out that patch, the cwd.t is not creating a valid symbolic link, so
the test should fail on VMS instead of passing like it does now.
Regards,
-John
[EMAIL PROTECTED]
Personal Opinion Only
