Yep... -2 stays... but -2 is only available to committers on a project, normal non-committer contributors can only mark -1 (at least by default, perhaps it can be configured to stay).
Ed On Tue, Oct 18, 2016 at 10:19 AM, Damjan Marion (damarion) < damar...@cisco.com> wrote: > -2 stays... > > On 18 Oct 2016, at 19:17, Edward Warnicke <hagb...@gmail.com> wrote: > > I'm fine with -2, but please note that -1 gets cleared with each new patch > set (and I believe this is also true for -2), meaning that its easy to > 'loose' the -2. > > I'd be OK with Drafts, except that Drafts are not public. We *can* switch > to having gerrit make Drafts public (I'd be fine with that). > > Ed > > On Tue, Oct 18, 2016 at 10:13 AM, Damjan Marion (damarion) < > damar...@cisco.com> wrote: > >> >> Folks, >> >> We just got 1st DO_NOT_MERGE patch merged in. >> >> Can we going forward stop this practice, and use “-2” or Drafts instead? >> >> Thanks, >> >> Damjan >> >> >> _______________________________________________ >> vpp-dev mailing list >> vpp-dev@lists.fd.io >> https://lists.fd.io/mailman/listinfo/vpp-dev > > > >
_______________________________________________ vpp-dev mailing list vpp-dev@lists.fd.io https://lists.fd.io/mailman/listinfo/vpp-dev
