My intention was "Now only transparent objects are rendered by the bucket 
sort". (as it doesn't have any benefit for solid ones)
The moving health bar was a side effect which I didn't notice. Again rendering 
animated components using the bucket sort is not what we want.

I would suggest fixing renderAnimComponent so that it doesn't have this 
side-effect.
(maybe pushing/popping the transform matrix)

- Gerard

PS. I'm quite busy at the moment, so please don't expect too much input from me.

-----Original Message-----
From: [EMAIL PROTECTED] on behalf of Per Inge Mathisen
Sent: Sat 2-6-2007 22:31
To: Development list
Subject: Re: [Warzone-dev] Oil anim fix patch
 
On 6/2/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
> So patch good or not?

I am curious as to why it is correct, and what else might break, not
just whether it fixes the bug. I see that gerard changed it in r1007:

------------------------------------------------------------------------
r1007 | gerard_ | 2007-04-05 17:24:03 +0200 (Thu, 05 Apr 2007) | 2 lines

1. Now only transparent objects are rendered by the bucket sort. 2.
Added some asserts to check if droids stay on the map.

@@ -1891,7 +1851,7 @@
                        psComp->orientation.y = vecRot.y;
                        psComp->orientation.z = vecRot.z;

-                       bucketAddTypeToList( RENDER_ANIMATION, psComp );
+                       renderAnimComponent( psComp );
                }
        }
 }

Gerard, any comment on how this should be fixed?

  - Per

_______________________________________________
Warzone-dev mailing list
Warzone-dev@gna.org
https://mail.gna.org/listinfo/warzone-dev

_______________________________________________
Warzone-dev mailing list
Warzone-dev@gna.org
https://mail.gna.org/listinfo/warzone-dev

Reply via email to