On 3/1/09, Per Inge Mathisen <[email protected]> wrote: > On Sat, Feb 28, 2009 at 10:42 PM, bugs buggy <[email protected]> wrote: > >> As I see it, this must be the bug > >> fix part: > >> + // Since ANYPLAYER is supposed to be controlled by host only, > that > >> creates a issue when > >> + // a MP player gets a feature, and it is 'ANYPLAYER' it would > never > >> send the destroy msg. > >> + if (!myResponsibility(pF->player) || !(pF->player == ANYPLAYER)) > > > >> You may well be right about the problem, but I do not see how this can > >> be a correct fix. This will AFAICT only destroy a feature if it is > >> owned by ANYPLAYER. > >> > >> - Per > > > > Oil drums are always player = 99. The myResponsibility() check > > returns true if host controls, or is player 99. This was a mistake, > > since when a client hits that check, they wouldn't be responsible for > > it. That is why the ANYPLAYER check. > > Adding that allows the clients to say 'yeah, we got that barrel, now > > tell the others'. > > > As far as I can tell, myResponsibility() returns false if player is > ANYPLAYER. I am pretty sure you want to say if > > (!myResponsibility(pF->player) && pF->player != ANYPLAYER) > > > - Per > Let me attempt to do a astral projection.... did it work? :D
Features will always have player set to ANYPLAYER, except if they are stuck on the map with EW right? That is why I had it the way I had it. I have tested it locally, between 2 machines, and it does work the way it is written now. If the feature is the responsibility of the player (EW created features on the map), || is ANYPLAYER, then we want to send the destroy message. _______________________________________________ Warzone-dev mailing list [email protected] https://mail.gna.org/listinfo/warzone-dev
