[
https://issues.apache.org/jira/browse/WAVE-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177910#comment-13177910
]
[email protected] commented on WAVE-275:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3294/#review4160
-----------------------------------------------------------
/src/org/waveprotocol/wave/client/editor/impl/AutoLinker.java
<https://reviews.apache.org/r/3294/#comment9394>
There are indentation inconsistencies in this class. Please keep the two
spaces indentation everywhere.
/src/org/waveprotocol/wave/client/editor/impl/AutoLinker.java
<https://reviews.apache.org/r/3294/#comment9387>
This import is unused.
/src/org/waveprotocol/wave/client/editor/impl/AutoLinker.java
<https://reviews.apache.org/r/3294/#comment9388>
This import is unused.
/src/org/waveprotocol/wave/client/editor/impl/AutoLinker.java
<https://reviews.apache.org/r/3294/#comment9385>
The indentation is different here. Should be two spaces.
/src/org/waveprotocol/wave/client/editor/impl/AutoLinker.java
<https://reviews.apache.org/r/3294/#comment9386>
Please allow one space after the double slash ant terminate the comment
with full stop
//Needed as an array to select individual ones later ->
// Needed as an array to select individual ones later.
/src/org/waveprotocol/wave/client/editor/impl/AutoLinker.java
<https://reviews.apache.org/r/3294/#comment9391>
The variable is not used.
/src/org/waveprotocol/wave/client/editor/impl/AutoLinker.java
<https://reviews.apache.org/r/3294/#comment9395>
Need space before and after operator, i.e.
i=0 -> i = 0
i<text.length-1 -> i < text.length -1
And also below.
/src/org/waveprotocol/wave/client/editor/impl/AutoLinker.java
<https://reviews.apache.org/r/3294/#comment9392>
Can we extract the scheme extraction logic into a separate method?
/src/org/waveprotocol/wave/client/editor/impl/AutoLinker.java
<https://reviews.apache.org/r/3294/#comment9393>
Can we move the declaration of "offset" to a new line?
/src/org/waveprotocol/wave/client/editor/impl/AutoLinker.java
<https://reviews.apache.org/r/3294/#comment9389>
Can we move this testStr calculation out of the inner for?
/src/org/waveprotocol/wave/client/editor/impl/AutoLinker.java
<https://reviews.apache.org/r/3294/#comment9390>
Is it safe to use here the "==" operator instead of equals() method?
- Yuri
On 2011-12-23 23:01:27, Ali Lown wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3294/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-23 23:01:27)
bq.
bq.
bq. Review request for wave and Yuri Zelikov.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Implements an auto-linker feature as requested.
bq.
bq. This implementation works by splitting the data by the uri seperator "://"
and then attempting to match the scheme to a known (currently hard-coded list)
of schemes. The end is detected by either a space or EOL.
bq.
bq. This implementation allows any character to be before a valid scheme, but
relies upon a space or EOL to find the end.
bq.
bq.
bq. This addresses bug WAVE-275.
bq. https://issues.apache.org/jira/browse/WAVE-275
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /src/org/waveprotocol/wave/client/editor/impl/AutoLinker.java
PRE-CREATION
bq. /src/org/waveprotocol/wave/client/StageThree.java 1213039
bq. /src/org/waveprotocol/wave/client/common/safehtml/EscapeUtils.java
1213039
bq. /src/org/waveprotocol/wave/client/doodad/link/Link.java 1213039
bq.
bq. Diff: https://reviews.apache.org/r/3294/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested manually by running the server and typing in URLs in various forms,
as well as by copy-pasting in.
bq.
bq.
bq. Thanks,
bq.
bq. Ali
bq.
bq.
> Auto-linking
> ------------
>
> Key: WAVE-275
> URL: https://issues.apache.org/jira/browse/WAVE-275
> Project: Wave
> Issue Type: New Feature
> Components: Web Client
> Reporter: Daniel Danilatos
> Assignee: Ali Lown
> Labels: StarterProject
>
> Implement auto-linking on the client. If the user types something that looks
> like a link, we should annotated it with "link/auto". This should probably be
> done in a listener to the editor's rate-limited udpate event, to avoid
> performance issues.
> This would be a pretty simple self contained starter project.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
