[
https://issues.apache.org/jira/browse/WAVE-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175614#comment-13175614
]
[email protected] commented on WAVE-275:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3294/
-----------------------------------------------------------
(Updated 2011-12-23 23:01:27.339607)
Review request for wave and Yuri Zelikov.
Changes
-------
Implements your suggested changes.
Doesn't implement a more efficient algorithm though (see comment about
EditorContext).
Summary
-------
Implements an auto-linker feature as requested.
This implementation works by splitting the data by the uri seperator "://" and
then attempting to match the scheme to a known (currently hard-coded list) of
schemes. The end is detected by either a space or EOL.
This implementation allows any character to be before a valid scheme, but
relies upon a space or EOL to find the end.
This addresses bug WAVE-275.
https://issues.apache.org/jira/browse/WAVE-275
Diffs (updated)
-----
/src/org/waveprotocol/wave/client/editor/impl/AutoLinker.java PRE-CREATION
/src/org/waveprotocol/wave/client/StageThree.java 1213039
/src/org/waveprotocol/wave/client/common/safehtml/EscapeUtils.java 1213039
/src/org/waveprotocol/wave/client/doodad/link/Link.java 1213039
Diff: https://reviews.apache.org/r/3294/diff
Testing
-------
Tested manually by running the server and typing in URLs in various forms, as
well as by copy-pasting in.
Thanks,
Ali
> Auto-linking
> ------------
>
> Key: WAVE-275
> URL: https://issues.apache.org/jira/browse/WAVE-275
> Project: Wave
> Issue Type: New Feature
> Components: Web Client
> Reporter: Daniel Danilatos
> Assignee: Ali Lown
> Labels: StarterProject
>
> Implement auto-linking on the client. If the user types something that looks
> like a link, we should annotated it with "link/auto". This should probably be
> done in a listener to the editor's rate-limited udpate event, to avoid
> performance issues.
> This would be a pretty simple self contained starter project.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
