[
https://issues.apache.org/jira/browse/WAVE-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175414#comment-13175414
]
[email protected] commented on WAVE-275:
----------------------------------------------------
bq. On 2011-12-22 22:25:41, Patrick Coleman wrote:
bq. > Nice work - the framework stuff is great, though this looks like it'd be
rather slow on a client with a large blip document;
bq. > can it be made faster? The editor update event should come with flags
(content changes / cursor changed etc) so only ones where the content changed
bq. > need to be inspected, and for those, only the content around the cursor
(which should also be available) need be inspected.
I wasn't aware of this contextual information being available. (I agree that
the current implementation could get quite slow with _very_ big documents. (Not
sure how often it would be found in practice (excluding mobile clients)).
bq. On 2011-12-22 22:25:41, Patrick Coleman wrote:
bq. > /src/org/waveprotocol/wave/client/editor/impl/AutoLinker.java, line 146
bq. > <https://reviews.apache.org/r/3294/diff/2/?file=65725#file65725line146>
bq. >
bq. > What's this part for? it seems to be for matching schemes by suffix
- e.g. thisisamailto:// will match mailto?
bq. >
bq. > Should these be matched, or just <whitespace/lines>mailto://
I was originally doing the splitting by whitespace and required it at both ends
to detect a link.
In my own usage though, I found I will often introduce a link with a '-' or a
':' without always using whitespace. Rather than creating a whitelist of
allowed characters before a url is detected, it is easier (for the user) if it
is auto-detected everywhere.
So, this was a deliberate choice.
bq. On 2011-12-22 22:25:41, Patrick Coleman wrote:
bq. > /src/org/waveprotocol/wave/client/editor/impl/AutoLinker.java, line 110
bq. > <https://reviews.apache.org/r/3294/diff/2/?file=65725#file65725line110>
bq. >
bq. > nit: lots of empty lines here.
My bad. Left over surrounding some (now removed) debugging code.
bq. On 2011-12-22 22:25:41, Patrick Coleman wrote:
bq. > /src/org/waveprotocol/wave/client/editor/impl/AutoLinker.java, line 185
bq. > <https://reviews.apache.org/r/3294/diff/2/?file=65725#file65725line185>
bq. >
bq. > feels like weird indentation here - 6 spaces whereas the method
above has 4 and the ones above that have 2.
Ok. I will sort this out and get a new diff on here tomorrow.
- Ali
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3294/#review4088
-----------------------------------------------------------
On 2011-12-22 16:43:51, Ali Lown wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3294/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-22 16:43:51)
bq.
bq.
bq. Review request for wave and Yuri Zelikov.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Implements an auto-linker feature as requested.
bq.
bq. This implementation works by splitting the data by the uri seperator "://"
and then attempting to match the scheme to a known (currently hard-coded list)
of schemes. The end is detected by either a space or EOL.
bq.
bq. This implementation allows any character to be before a valid scheme, but
relies upon a space or EOL to find the end.
bq.
bq.
bq. This addresses bug WAVE-275.
bq. https://issues.apache.org/jira/browse/WAVE-275
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /src/org/waveprotocol/wave/client/StageThree.java 1213039
bq. /src/org/waveprotocol/wave/client/common/safehtml/EscapeUtils.java
1213039
bq. /src/org/waveprotocol/wave/client/doodad/link/Link.java 1213039
bq. /src/org/waveprotocol/wave/client/editor/impl/AutoLinker.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/3294/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested manually by running the server and typing in URLs in various forms,
as well as by copy-pasting in.
bq.
bq.
bq. Thanks,
bq.
bq. Ali
bq.
bq.
> Auto-linking
> ------------
>
> Key: WAVE-275
> URL: https://issues.apache.org/jira/browse/WAVE-275
> Project: Wave
> Issue Type: New Feature
> Components: Web Client
> Reporter: Daniel Danilatos
> Assignee: Ali Lown
> Labels: StarterProject
>
> Implement auto-linking on the client. If the user types something that looks
> like a link, we should annotated it with "link/auto". This should probably be
> done in a listener to the editor's rate-limited udpate event, to avoid
> performance issues.
> This would be a pretty simple self contained starter project.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
