[
https://issues.apache.org/jira/browse/WAVE-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185857#comment-13185857
]
[email protected] commented on WAVE-275:
----------------------------------------------------
bq. On 2011-12-22 22:25:41, Patrick Coleman wrote:
bq. > Nice work - the framework stuff is great, though this looks like it'd be
rather slow on a client with a large blip document;
bq. > can it be made faster? The editor update event should come with flags
(content changes / cursor changed etc) so only ones where the content changed
bq. > need to be inspected, and for those, only the content around the cursor
(which should also be available) need be inspected.
bq.
bq. Ali Lown wrote:
bq. I wasn't aware of this contextual information being available. (I
agree that the current implementation could get quite slow with _very_ big
documents. (Not sure how often it would be found in practice (excluding mobile
clients)).
bq.
bq. Ali Lown wrote:
bq. Looking at EditorContext (the information passed by
EditorUpdateListener.onUpdate), I don't appear to be able to retrieve the
location of the changes (only of a selection), just a few boolean flags to
state that the content has cahnged.
bq.
bq. Yuri Zelikov wrote:
bq. Take a look at EditToolbar#insertGadget method - you can find there
example on how to find the location of current change.
Bump to keep this up-to-date:
- I have now implemented Yuri's suggestions below
- Based on the code in EditToolbar#insertGadget I can now get the link checks
to be performed only near the users's edits, but this is also causing a new
problem:
Because the EditorUpdate event I listed to is rate-limited, in some situations
it has now become possible to only get links missed because by the time the
Update event gets fired, the cursor's location is now further ahead and the
link gets 'skipped over'.
Preventing this occurring is what I am currently working on.
PS. Sorry exams ATM (A2 modules - UK system) so my time for finishing this off
is limited for the next 2 weeks.
- Ali
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3294/#review4088
-----------------------------------------------------------
On 2011-12-23 23:01:27, Ali Lown wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3294/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-23 23:01:27)
bq.
bq.
bq. Review request for wave and Yuri Zelikov.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Implements an auto-linker feature as requested.
bq.
bq. This implementation works by splitting the data by the uri seperator "://"
and then attempting to match the scheme to a known (currently hard-coded list)
of schemes. The end is detected by either a space or EOL.
bq.
bq. This implementation allows any character to be before a valid scheme, but
relies upon a space or EOL to find the end.
bq.
bq.
bq. This addresses bug WAVE-275.
bq. https://issues.apache.org/jira/browse/WAVE-275
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /src/org/waveprotocol/wave/client/editor/impl/AutoLinker.java
PRE-CREATION
bq. /src/org/waveprotocol/wave/client/StageThree.java 1213039
bq. /src/org/waveprotocol/wave/client/common/safehtml/EscapeUtils.java
1213039
bq. /src/org/waveprotocol/wave/client/doodad/link/Link.java 1213039
bq.
bq. Diff: https://reviews.apache.org/r/3294/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested manually by running the server and typing in URLs in various forms,
as well as by copy-pasting in.
bq.
bq.
bq. Thanks,
bq.
bq. Ali
bq.
bq.
> Auto-linking
> ------------
>
> Key: WAVE-275
> URL: https://issues.apache.org/jira/browse/WAVE-275
> Project: Wave
> Issue Type: New Feature
> Components: Web Client
> Reporter: Daniel Danilatos
> Assignee: Ali Lown
> Labels: StarterProject
>
> Implement auto-linking on the client. If the user types something that looks
> like a link, we should annotated it with "link/auto". This should probably be
> done in a listener to the editor's rate-limited udpate event, to avoid
> performance issues.
> This would be a pretty simple self contained starter project.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
