----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3296/#review4097 -----------------------------------------------------------
/src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java <https://reviews.apache.org/r/3296/#comment9218> It seems like there's white space /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java <https://reviews.apache.org/r/3296/#comment9219> Please remove whitespace /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java <https://reviews.apache.org/r/3296/#comment9220> It seems like user registration is an important event, so it might be a good idea to add some mechanism to register a listener on a new user registration - Similar to RobotRegistrar. But it can be done it other patch as well. /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java <https://reviews.apache.org/r/3296/#comment9222> Would be nice to add a test for this method. /src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java <https://reviews.apache.org/r/3296/#comment9216> Can we adjust the comment for Registration Robot? - Yuri On 2011-12-22 23:52:27, Ali Lown wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3296/ > ----------------------------------------------------------- > > (Updated 2011-12-22 23:52:27) > > > Review request for wave. > > > Summary > ------- > > Implements suggestions in WAVE-313: > - Adds a hideRegistration option to the server config file > - Removes the auth/registration route when this is the case > - Adds a RegistrationRobot to let the admin user always create new users > > Know limitations/features: > - Doesn't remove any 'register' links - server 404s when they are clicked. > - Manually created users don't get WelcomeBot'd > > > This addresses bug WAVE-313. > https://issues.apache.org/jira/browse/WAVE-313 > > > Diffs > ----- > > /server-config.xml 1213039 > /server.config.example 1213039 > /src/org/waveprotocol/box/server/CoreSettings.java 1213039 > /src/org/waveprotocol/box/server/ServerMain.java 1213039 > /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java 1213039 > > /src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/3296/diff > > > Testing > ------- > > Compiled + run. Tried to access auth/register with hideRegistration=false and > hideRegistration=true. > Logged in as the admin user and tried to create new accounts with the > RegistrationRobot - then logged into new accounts to check valid. > > > Thanks, > > Ali > >
