-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3296/
-----------------------------------------------------------
(Updated 2012-01-04 15:37:37.798794)
Review request for wave.
Changes
-------
*) Moved enabled/disabled servlet to the relevant function
*) Add your suggested LOC to the test. Technically I didn't put the PrintWriter
in it was already like that, but now it gets properly tested.
Summary
-------
Implements suggestions in WAVE-313:
- Adds a hideRegistration option to the server config file
- Removes the auth/registration route when this is the case
- Adds a RegistrationRobot to let the admin user always create new users
Know limitations/features:
- Doesn't remove any 'register' links - server 404s when they are clicked.
- Manually created users don't get WelcomeBot'd
This addresses bug WAVE-313.
https://issues.apache.org/jira/browse/WAVE-313
Diffs (updated)
-----
/server-config.xml 1213039
/server.config.example 1213039
/src/org/waveprotocol/box/server/CoreSettings.java 1213039
/src/org/waveprotocol/box/server/ServerMain.java 1213039
/src/org/waveprotocol/box/server/gxp/UserRegistrationPage.gxp 1213039
/src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java 1213039
/src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java
PRE-CREATION
/src/org/waveprotocol/box/server/rpc/UserRegistrationServlet.java 1213039
/test/org/waveprotocol/box/server/rpc/UserRegistrationServletTest.java
1213039
Diff: https://reviews.apache.org/r/3296/diff
Testing
-------
Compiled + run. Tried to access auth/register with hideRegistration=false and
hideRegistration=true.
Logged in as the admin user and tried to create new accounts with the
RegistrationRobot - then logged into new accounts to check valid.
Thanks,
Ali
