Just nitpicks. LGTM after a final read through from Yuri since I am having a hard time reading code style using this tool :S.
- Lennard On Thu, Jan 5, 2012 at 21:41, Lennard de Rijk <[email protected]> wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3296/ > > /src/org/waveprotocol/box/server/rpc/UserRegistrationServlet.java<https://reviews.apache.org/r/3296/diff/4/?file=66369#file66369line63> > (Diff > revision 4) > > 63 > > @Named(CoreSettings.DISABLE_REGISTRATION) boolean disableRegistration) { > > Rename in this class to registrationDisabled for better readability. > > > > /src/org/waveprotocol/box/server/rpc/UserRegistrationServlet.java<https://reviews.apache.org/r/3296/diff/4/?file=66369#file66369line81> > (Diff > revision 4) > > 78 > > String responseType = AuthenticationServlet.RESPONSE_STATUS_SUCCESS; > > 80 > > String responseType = AuthenticationServlet.RESPONSE_STATUS_SUCCESS; > > While you are here can you move this line into the else statement where the > registration actually completes. It makes the intention much clearer if you'd > ask me. > > > - Lennard > > On January 4th, 2012, 3:37 p.m., Ali Lown wrote: > Review request for wave. > By Ali Lown. > > *Updated 2012-01-04 15:37:37* > Description > > Implements suggestions in WAVE-313: > - Adds a hideRegistration option to the server config file > - Removes the auth/registration route when this is the case > - Adds a RegistrationRobot to let the admin user always create new users > > Know limitations/features: > - Doesn't remove any 'register' links - server 404s when they are clicked. > - Manually created users don't get WelcomeBot'd > > Testing > > Compiled + run. Tried to access auth/register with hideRegistration=false and > hideRegistration=true. > Logged in as the admin user and tried to create new accounts with the > RegistrationRobot - then logged into new accounts to check valid. > > *Bugs: * WAVE-313 <https://issues.apache.org/jira/browse/WAVE-313> > Diffs > > - /server-config.xml (1213039) > - /server.config.example (1213039) > - /src/org/waveprotocol/box/server/CoreSettings.java (1213039) > - /src/org/waveprotocol/box/server/ServerMain.java (1213039) > - /src/org/waveprotocol/box/server/gxp/UserRegistrationPage.gxp > (1213039) > - /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java > (1213039) > - > /src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java > (PRE-CREATION) > - /src/org/waveprotocol/box/server/rpc/UserRegistrationServlet.java > (1213039) > - /test/org/waveprotocol/box/server/rpc/UserRegistrationServletTest.java > (1213039) > > View Diff <https://reviews.apache.org/r/3296/diff/> >
