----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3296/#review4235 -----------------------------------------------------------
Ship it! Committed as r1228584. Thanks for the effort! Please close this review request. - Yuri On 2012-01-06 19:31:13, Ali Lown wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3296/ > ----------------------------------------------------------- > > (Updated 2012-01-06 19:31:13) > > > Review request for wave. > > > Summary > ------- > > Implements suggestions in WAVE-313: > - Adds a hideRegistration option to the server config file > - Removes the auth/registration route when this is the case > - Adds a RegistrationRobot to let the admin user always create new users > > Know limitations/features: > - Doesn't remove any 'register' links - server 404s when they are clicked. > - Manually created users don't get WelcomeBot'd > > > This addresses bug WAVE-313. > https://issues.apache.org/jira/browse/WAVE-313 > > > Diffs > ----- > > /server-config.xml 1213039 > /server.config.example 1213039 > /src/org/waveprotocol/box/server/CoreSettings.java 1213039 > /src/org/waveprotocol/box/server/ServerMain.java 1213039 > /src/org/waveprotocol/box/server/gxp/UserRegistrationPage.gxp 1213039 > /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java 1213039 > > /src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java > PRE-CREATION > /src/org/waveprotocol/box/server/rpc/UserRegistrationServlet.java 1213039 > /test/org/waveprotocol/box/server/rpc/UserRegistrationServletTest.java > 1213039 > > Diff: https://reviews.apache.org/r/3296/diff > > > Testing > ------- > > Compiled + run. Tried to access auth/register with hideRegistration=false and > hideRegistration=true. > Logged in as the admin user and tried to create new accounts with the > RegistrationRobot - then logged into new accounts to check valid. > > > Thanks, > > Ali > >
