On Wed, 2006-03-22 at 09:50 +0800, Ow Mun Heng wrote: > Hi All, > > I'm (again) wondering how come this patch wasn't accepted upstream. I > was having a "day" with this trying to figure out what was happening > with my configuration. I couldn't get "proper" usernames to login into > cyrus-imapd.
I was approached about it once, but nothing really happened, plus I dont believe the patch is as good as it needs to be to be fully integrated into CVS. > with this patch > http://www.shaolinux.org/web-cyradm-0.5.4.new.diff (though I've not > tried it out yet) This patch is written for 0.5.4, the CVS version has not been tested with this patch, also extensive testing is required to ensure that changes from this patch do not affect normal operation so those who do not want to use FQUN will not be affected. > and this > http://www.web-cyradm.org/pipermail/web-cyradm/2004-April/017369.html > 1 line change > > --- newaccount.php.orig 2004-04-09 16:48:49.000000000 +0200 > > +++ newaccount.php 2004-04-09 16:49:40.000000000 +0200 > > @@ -187,7 +187,7 @@ > > $prefix = $domain; > > $username = $email; > > if ($freenames!="YES") { > > - $username = $username . "." . $domain; > > + $username = $username . "@" . $domain; > > } > > $seperator = '/'; > > } else { > This one line change allows you to use FQUN, however it would break non-FQUN setups and it also breaks certain functions of web-cyradm. > Can I just inquire why this wasn't accepted upstream? (I was actually > thinking of hacking the source to accept this change and send it in as a > patch) Feel free to do it, I plan on eventually upgrading to CVS version and patching it for FQUN but I'm not sure when. _______________________________________________ This mailing list is hosted and supported by bit-heads GmbH | http://www.bit-heads.ch _______________________________________________ Web-cyradm mailing list [email protected] http://www.web-cyradm.org/mailman/listinfo/web-cyradm
