On Fri, Nov 2, 2012 at 12:33 PM, Antti Koivisto <[email protected]> wrote:

> On Wed, Oct 31, 2012 at 12:05 AM, Alexey Proskuryakov <[email protected]>wrote:
>
>> This will mean that cache is always almost empty, and all resources in it
>> are extremely fresh. I don't know if this would provide substantial
>> additional test coverage over cleaning the cache all the time, or just
>> completely disabling it in WebKitTestRunner.
>>
>
> Certain areas of coverage would improve. The code paths taken when a
> resource is restored from the memory cache can be quite different from the
> usual loading. Many operations (like script execution) happen synchronously
> if the resource is found from the cache. We reuse various decoded forms
> (bitmaps, stylesheets, jsc parse structures, likely more in the future).
> All data is available in single chunk. It is possible to write tests that
> detect these differences (and it is possible that some tests hit them
> accidentally).
>
> We would still lose coverage for things that depend on having lots of
> resources around like cache pruning.
>
>
In this case to improve code coverage all tests should run twice - 1st with
clear cache and 2nd run after that in order to test cached case.

Slava
_______________________________________________
webkit-dev mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-dev

Reply via email to