15 янв. 2014 г., в 23:02, Ryosuke Niwa <rn...@webkit.org> написал(а):

> I think that it's good to try not dumping build failures into comments right 
> away, and to see what happens.
> 
> As for not showing style bot failures, it seems almost certain that this will 
> make them substantially more annoying to work with. Can you describe the 
> workflow for patch author and reviewer to deal with style bot warnings when 
> they are not inline? Manually finding relevant lines by number can't work.
> 
> I agree with Tim that dumping all tested paths along with style warnings is 
> silly. How hard would it be it to get rid of that?
> 
> The workflow is to click on the bubble to see the style errors. e.g.
> https://webkit-queues.appspot.com/results/6544662978363392


Seems like that would require everyone to manually match errors to code lines 
indeed, so I object against making this change for style checker warnings.

- WBR, Alexey Proskuryakov
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Reply via email to