I dislike this change now that's been rolled out. The lack of email notices before confirmed that my patch was OK and I was able to do something else while waiting for review. Now I have to continually revisit the bug page checking to see if more bots have completed and that my patch is good.
I think at least the person who submitted the patch should be notified when there's been an error. On Jan 17, 2014, at 4:27 PM, Alexey Proskuryakov <a...@webkit.org> wrote: > > This has been implemented, and one unintended consequence is that this > noticeably affects how quickly one can iterate on time sensitive patches. > > It's a huge waste of time that you are no longer informed when a build fails > on EWS. This seriously delays urgent work, as you only start working on fixes > when you happen to manually poll, or even worse, when a reviewer tells you > about build breakage. > > It's good to not spam everyone, however patch author should be notified by > EWS immediately I think. Some ideas: > > - e-mail; > - IRC; > - browser notifications when bug page is open. > > The latter might be best, as it also gives some control over whether to get > pinged - keep the bug open if you care, close it if it's not urgent, and you > cannot afford distraction now. > > I filed https://bugs.webkit.org/show_bug.cgi?id=127203 about this. > > - WBR, Alexey Proskuryakov > > > 16 янв. 2014 г., в 15:09, Ryosuke Niwa <rn...@webkit.org> написал(а): > >> Okay, let's remove the python paths but keep the style error messages until >> we can improve the EWS infrastructure. >> >> - R. Niwa >> >> >> On Thu, Jan 16, 2014 at 9:41 AM, Timothy Hatcher <timo...@apple.com> wrote: >> On Jan 16, 2014, at 2:28 AM, Alexey Proskuryakov <a...@webkit.org> wrote: >> >>> >>> 15 янв. 2014 г., в 23:02, Ryosuke Niwa <rn...@webkit.org> написал(а): >>> >>>> I think that it's good to try not dumping build failures into comments >>>> right away, and to see what happens. >>>> >>>> As for not showing style bot failures, it seems almost certain that this >>>> will make them substantially more annoying to work with. Can you describe >>>> the workflow for patch author and reviewer to deal with style bot warnings >>>> when they are not inline? Manually finding relevant lines by number can't >>>> work. >>>> >>>> I agree with Tim that dumping all tested paths along with style warnings >>>> is silly. How hard would it be it to get rid of that? >>>> >>>> The workflow is to click on the bubble to see the style errors. e.g. >>>> https://webkit-queues.appspot.com/results/6544662978363392 >>> >>> >>> Seems like that would require everyone to manually match errors to code >>> lines indeed, so I object against making this change for style checker >>> warnings. >>> >>> - WBR, Alexey Proskuryakov >> >> Yeah, seeing the style warnings as a comment (which also causes them to show >> up in the patch review) is helpful. I was just complaining about the python >> path spew it also includes. >> >> — Timothy Hatcher >> > > > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
