On 2012-03-28, at 9:22 AM, David Avendasora wrote:
>
> On Mar 28, 2012, at 2:13 PM, Johann Werner wrote:
>
>> Perhaps now it is the time to define a mandatory Wonder code formatter all
>> commits have to use. I think that would make it easier for many committers
>> to send patches without worrying about formatting – and it would improve the
>> code readability/quality.
>
>
> Code formatting can turn into a religious war. Lots of fervent belief, with
> little evidence to back it up.
>
> I _love_ how I format my code. I've had other's heads explode when they look
> at it. (Hi Dawn!)
>
> WIth that said, I think some basics would certainly be helpful, and it's easy
> to create a set of formatting rules that can be imported into Eclipse.
>
> I'd say #1 change that would make the code easier for me to read is no
> freakin' conditionals in the return statement.
>
> return contentDisposition != null && (contentDisposition.indexOf("inline") >
> -1 || contentDisposition.indexOf("attachment") > -1);
>
> Seriously, who can read that and make sense of it immediately?!
This is programmers shorthand. They master it with time. If you find these
statements somewhere in the code, consider that piece of code been written by
an experienced programmer which is less likely to have bugs. This is style is
still not difficult than what you can find in a TopCoder algorithm which
contains is full of boolean and bit manipulation operators.
I would say, whoever can contribute a single bit, just do it. Formatting is not
a major issue. I would do what the following statement returns :)
return "does it exist what you're looking for" ? ("do you find any performance
issues" ? "improve, use and share" : "use and appreciate") : "implement, use
and share";
Farrukh
>
> Dave
>
> —————————————————————————————
> WebObjects - so easy that even Dave Avendasora can do it!™
> —————————————————————————————
> David Avendasora
> Senior Software Abuser
> Kaiten, Inc.
>
>
>
>
> _______________________________________________
> Do not post admin requests to the list. They will be ignored.
> Webobjects-dev mailing list (Webobjects-dev@lists.apple.com)
> Help/Unsubscribe/Update your Subscription:
> https://lists.apple.com/mailman/options/webobjects-dev/farrukh.ijaz%40fuegodigitalmedia.com
>
> This email sent to farrukh.i...@fuegodigitalmedia.com
_______________________________________________
Do not post admin requests to the list. They will be ignored.
Webobjects-dev mailing list (Webobjects-dev@lists.apple.com)
Help/Unsubscribe/Update your Subscription:
https://lists.apple.com/mailman/options/webobjects-dev/archive%40mail-archive.com
This email sent to arch...@mail-archive.com
