HI
- have you guys checked on the performance hit for dtrace enabled ruby 
vs without ?

- if you used  ', or @'  for sed pattern match, then you  probably don't 
have to do \/ . could help in readability.

sed -e 's/CONFIG\[\"CC\"\].*$/CONFIG\[\"CC\"\] = \"\/usr\/sfw\/bin\/gcc\"/' \
+-e 's/CONFIG\[\"CFLAGS\"\].*$/CONFIG\[\"CFLAGS\"\] = \"-g -O3 -fPIC\"/' \
+-e 's/CONFIG\[\"LDFLAGS\"\].*$/CONFIG\[\"LDFLAGS\"\] = \"-L\/usr\/sfw\/lib 
-R\/usr\/sfw\/lib\"/' \
+-e 's/CONFIG\[\"CPP\"\].*$/CONFIG\[\"CPP\"\] = \"\/usr\/sfw\/bin\/gcc -E\"/' \
+-e 's/CONFIG\[\"CPPFLAGS\"\].*$/CONFIG\[\"CPPFLAGS"\] = 
\"-I\/usr\/sfw\/include\"/' \
+-e 's/CONFIG\[\"INSTALL\"\].*$/CONFIG\[\"INSTALL"\] = \"\/usr\/bin\/ginstall 
-c\" /' \
+-e 's/CONFIG\[\"CCDLFLAGS\"\].*$/CONFIG\[\"CCDLFLAGS\"\] = \"-fPIC\"/' 
${LIBDIR}/ruby/1.8/${MACH}-solaris2${RELEASENUM}/rbconfig.rb > rbconfig.mod
+


looks good to me , otherwise

Chris Zhu wrote:
> Hi all,
>
> Here's the webrev for CR6764580 & CR6788394,  see 
> http://cr.opensolaris.org/~chriszhu/ruby187_gem131/
> "6764580 RubyGems needs updating to work with the latest versions of 
> Ruby on Rails"
> "6788394 Upgrade Ruby to 1.8.7",
> Now ruby 1.8.7 and rubygem 1.3.1 are widely used in most of the web 
> apps, we'd like to put both of them into webstack, please help to review.
> It depends on the rubygem upgrade to 1.3.1 which has been raised by 
> Amanda, following link gives more detail info:
> http://cr.opensolaris.org/~tekgrrl/gems131-CR6764580-2/
> http://www.opensolaris.org/jive/thread.jspa?threadID=89892&tstart=0,
> then we added "upgrade ruby  to 1.8.7" into the same workspace.
>
> Regards
> Chris
> _______________________________________________
> sfwnv-discuss mailing list
> sfwnv-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
>   

Reply via email to