Chris Zhu wrote: > > Right, the question was why; more importantly, whether there is any > functionality impact to this removal? Is it just Project Private > implementation detail where some files moved around or is it that some > functionality related to enumerator.so and/or largefile.h was removed > in this release? > > 1) usr/ruby/1.8/lib/ruby/1.8/i386-solaris{SOL_REV}/enumerator.so > There's no enumerator module listed in ruby1.8.7-p72/ext, which is for > enumerator.so as ruby 1.8.6. > 2) usr/ruby/1.8/lib/ruby/1.8/i386-solaris{SOL_REV}/largefile.h > According to the Change Log of ruby1.8.7-p72, largefile.h is removed > the source code. > Tue Jan 29 11:53:05 2008 Nobuyoshi Nakada [1]<nobu at ruby-lang.org> > > * configure.in: rm largefile.h.
Yes, I can see from the webrev these files are gone. The open question is why and what is the impact, if any? Most likely it is just project private detail moving around, but if you don't know that for sure yet, you need to do the due diligence investigation to find out and convince yourself (and me) that it's indeed just implementation detail change and not something which can have an impact on user-visible functionality. > BTW, shall we change the wx ea for comments? Amanda's suggestion to cover that cleanup with the main version upgrade CR (6788394) sounds ok to me. Don't list multiple CRs on a file where the only change is this kind of cleanup (one example: http://cr.opensolaris.org/~chriszhu/ruby187_gem131/usr/src/pkgdefs/SUNWruby18r/prototype_sparc.udiff.html) -- Jyri J. Virkki - jyri.virkki at sun.com - Sun Microsystems