Chris Zhu wrote: > > The webrev is updated on > http://cr.opensolaris.org/~chriszhu/ruby187_gem131/.
Nit, but noticed according to the webrev usr/src/cmd/ruby18/Solaris/scripts/gemri has different permissions to all the other scripts (though I see it's corrected in post install anyway). Another nit, each file should list in its comments only the CR(s) which apply to the changes done to that file, not all CR(s) for the putback as a whole. One example, usr/src/pkgdefs/SUNWruby18r/prototype_i386 seems to only clean up the ident line, so that change isn't related to either of the two CRs listed. There's a handful other cases like this. usr/src/pkgdefs/SUNWruby18u/prototype_i386.tmpl (&sparc) What is the functionality impact, if any, of the .so and .h file which are being removed? -- Jyri J. Virkki - jyri.virkki at sun.com - Sun Microsystems
