Please see inline Thanks Sunanda
Bjorn Munch wrote: > A few comments: > > General: > > You have added both CR's to the checkin comments to all files. I > think maybe the one for DTrace should be applied only to those few > files actually touched by this CR. > I was not sure as the dtrace patch is also a part of the source ,then how do you say I need to put comments only to the files that are touched . What should they be then ? > usr/src/Targetdirs: > > Near your addition you have modified the line with /etc/sane.d, > apparently replacing a tab with a space. I suggest you don't do that > to avoid having an "artificial" change. > > I'll just check this > usr/src/cmd/mysql-5-1/Makefile.sfw: > > MYSQL_VERSION could have been split into a MAJOR part (which would be > fixed at "5.1" and could be referred to when used in paths) and a > MINOR part which could later be updated. But I wouldn't insist on > it... > > I see you use ksh93 for the install scripts (which won't work in sh), > but do you also need to run ./configure through ksh? > > I see both of the above have been coped from the 5.0 Makefile.sfw. > > usr/src/cmd/mysql-5-1/Solaris/mysql_51.1.sunman > > Should this really refer to the minor version number? I don't think > man pages usually do that (and the ones we include with PopstgreSQL > don't). > > Postgres seems to be doing the similar way .Please check this. Let me know if this is not the case and I'll change them . bash-3.2$ pwd /builds/sunanda/6711903/usr/src/cmd/postgres/postgresql-8.3/Solaris/man5 bash-3.2$ ls -l total 15 drwxrwxrwx 2 sm156471 staff 3 Jul 15 02:54 SCCS -r--r--r-- 1 sm156471 staff 18383 Jul 15 02:55 postgres_83.5 bash-3.2$ cd ../../../ bash-3.2$ cd postgresql-8.2/Solaris/man5 bash-3.2$ ls -l total 15 drwxrwxrwx 2 sm156471 staff 3 Jul 15 02:54 SCCS -r--r--r-- 1 sm156471 staff 17739 Jul 15 02:55 postgres_82.5 bash-3.2$ pwd /builds/sunanda/6711903/usr/src/cmd/postgres/postgresql-8.2/Solaris/man5 bash-3.2$ -- Sunanda Menon Database Technology Group BLR03, x87098/91-80-66937098
