On 07/08 10.30, Sunanda Menon wrote: > Please see inline > > Thanks Sunanda > > Bjorn Munch wrote: > > A few comments: > > > > General: > > > > You have added both CR's to the checkin comments to all files. I > > think maybe the one for DTrace should be applied only to those few > > files actually touched by this CR. > > > > I was not sure as the dtrace patch is also a part of the source ,then > how do you say I need to put comments only to the files that are touched . > What should they be then ?
Simply put: any file which is different from what it would be without the dtrace patch, or would have had to change if this was applied separately. For example the man page, but not (I think) the Makefile.sfw. I don't think this is very important though; better add too many than too few checkin comments. > > usr/src/cmd/mysql-5-1/Solaris/mysql_51.1.sunman > > > > Should this really refer to the minor version number? I don't think > > man pages usually do that (and the ones we include with PopstgreSQL > > don't). > > > > > Postgres seems to be doing the similar way .Please check this. > Let me know if this is not the case and I'll change them . For PostgreSQL, "8.2" or "8.3" are considered major version numbers and the man pages refer to those. I was not referring to the name of the man page, but the version number mentied in it. The postgres_83(5) man page refers to version 8.3, not 8.3.1 or 8.3.3. But the mysql_51 man page refers explicitly to version 5.1.25 instead of just 5.1. So, if 5.1 is updated to minor version 5.1.26, the man page has to be updated too even if there's no other change. -- Bjorn Munch Sun Microsystems Trondheim, Norway http://sun.com/postgresql/
